search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
173 stars 114 forks source link

Improve error message if transaction cannot be completed #583

Closed gary-rowe closed 9 years ago

gary-rowe commented 9 years ago

At present the contents of the exception returned from Bitcoinj are presented, which can be "null" if a transaction cannot be completed due to unconfirmed transactions during an empty operation.

gary-rowe commented 9 years ago

As an interim measure, I've added an English-only error message to give some indication of the failure:

screen shot 2015-05-30 at 21 43 42

Ready for review and close.

jim618 commented 9 years ago

I just did an empty wallet with unconfirmed tx and did not see this message (tx was sent fine - it leaves the unconfirmed which is what you would expect).

I have done a code review to check that the edge case is covered as per the OP so closing.