No 'OER is not responding' for OER rates

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet

https://multibit.org/blog/2017/07/26/multibit-shutdown.html

Other

172 stars 113 forks source link

No 'OER is not responding' for OER rates #638

Closed jim618 closed 9 years ago

jim618 commented 9 years ago

I usually use OpenExchangeRate. It has not been supplying data regularly in the last day or two but I am NOT seeing a 'OpenExchangeRate is not responding' alert at start up.

MBHD fails over cleanly - you just don't get fiat info but there should be an alert

jim618 commented 9 years ago

Looks like it's a redirect:

screen shot 2015-06-30 at 15 31 19

So OER has probably changed it's interface. Anywhich way MBHD should respond appropriately

jim618 commented 9 years ago

OER seems to be working now but there probably needs to be some tidy up so that it fails over better

jim618 commented 9 years ago

I have added in a check for HttpStatusIOException which I think will cover it. You can check for a related HTTP error code (409 - Conflict) by setting your exchange to OER/ GBP and then trying to switch to Hitbtc. The HTTP error code gets exposed on the UI correctly.

I believe this should also catch similar 303 errors when they occur again. (OER is not showing these errors currently.

Awaiting review and closing

gary-rowe commented 9 years ago

Reduced error logging level. Closing.