search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
172 stars 113 forks source link

First time MBHD starts up each day the splash screen is blank #646

Closed jim618 closed 9 years ago

jim618 commented 9 years ago

The first time MBHD starts up each day on my Mac the splash screen is blank gray. There is no image. Subsequent start ups it renders ok.

gary-rowe commented 9 years ago

Looking over the code in MultiBitHD.java line 112 it appears that the AWT splash screen is getting launched within a Swing EDT thread. This is incorrect. The splash screen is deliberately outside of Swing so that it will render using AWT's heavyweight components while the Nimbus LaF is still loading in the background. This gives a faster time to show.

I've removed the EDT code and added a very short Thread.sleep() to allow AWT time to render the splash screen image. This should give reliable splash screen rendering.

I'm unsure of why the EDT wrapping was introduced - it might have been in response to FEST tests moaning about EDT requirements. Can you verify this?

Ready for review and close.

jim618 commented 9 years ago

I've built an installer with the updated code and tried it several times, including straight from a reboot. Each time the splash screen rendered correctly.

I am not sure why it was added to the Swing EDT - over zealous SwingUtilities wrapping probably. Closing