search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
172 stars 113 forks source link

Sign message failure #668

Closed jim618 closed 8 years ago

jim618 commented 9 years ago 
"_source": {
"@timestamp": "2015-07-18T10:19:55.902+03:00",
"level": "ERROR",
"thread_name": "AWT-EventQueue-0",
"logger_name": "org.multibit.hd.core.error_reporting.ExceptionHandler",
"message": "Uncaught exception. Proceeding to show Error Reporting dialog...",
"stack_trace": "java.lang.IllegalStateException: Optional.get() cannot be called on an absent value
 at com.google.common.base.Absent.get(Absent.java:47) ~[multibit-hd.jar:na]
 at org.multibit.hd.ui.views.wizards.Wizards.newSignMessageWizard(Wizards.java:244) ~[multibit-hd.jar:na]
 at org.multibit.hd.ui.views.screens.tools.ToolsScreenView$3.actionPerformed(ToolsScreenView.java:101) ~[multibit-hd.jar:na]
 at javax.swing.AbstractButton.fireActionPerformed(Unknown Source) ~[na:1.7.0_80]
 at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source) ~[na:1.7.0_80]
jim618 commented 8 years ago

I have added in some defensive code in WalletMode to trap this error. I think the problem is that the status of the hardwareWalletService optional changes racily. I've caught the IllegalArgumentException and returned a Standard wallet mode rather than throw it out to the ErrorReporter.

Awaiting review and closing.

gary-rowe commented 8 years ago

Seems sensible. Closing.