Blank datestamp prevents restore

[gary-rowe]

User feedback has indicated that leaving the datestamp blank prevents progressing through the restore process.

Since this is on the critical path and I'm AFK can you take a look at this @jim618 and verify that a restore is possible? If not then it needs to be fixed in 0.1.3.

[jim618]

I just restored a MBHD wallet from the latest develop code with no datestamp successfully. Here it is synchronising:

This was done in the normal way e.g.:

• Press 'Restore' from password entry screen
• Enter wallet words
• Press 'Next' for entry of cloud backup location (i.e. skip)
• Enter only a wallet password - leave datestamp empty.
• 'Press 'Next' to 'Wallet report' screen.

There were no errors or anything unusual in the log file.

As MBHD has to to sync from the HD wallet creation 'birthday' it does take a while to sync (say an hour), but then that is the point of the datestamp in the first place.

Closing as 'Restore with no datestamp' is working correctly.

[woodydeck]

I was able to both replicate the issue, and also get it to work. Something is odd.

[woodydeck]

Try doing that, but clicking in the field of the datestamp, or entering something then deleting it, and then adding a password. You will get it greyed out. That might be the issue. Going to previous steps does not reset anything, and the problem persists. This is the restore of a Trezor wallet, I am not sure if it differs from the other restore methods.

Edit: If you don't click the datestamp field, then it works. If you click it, but add nothing, then you cannot restore the wallet without it.

[jim618]

I'll have a look at the datestamp field validation

[jim618]

I have put in a fix so that a blank datestamp also enables the 'Next>' button on the 'Enter datestamp' screen.

It's not exactly perfect as the 'Verified' on the datestamp is a little consistent. If the user enters a password with no datestamp the datestamp shows as 'Verified' but then if they enter some datestamp text and then remove it the 'Verified' initially disappears (correctly) they don't see the 'Verified' come back when the field is empty. This is due to a magic value - the HD birthday - being stored in the model (but not being shown on the view). I've left this as it is minor.

Awaiting review and closing.

[woodydeck]

Simplest workaround to avoid confusion then is not to change code, but add a checkbox to enable the field. Guess you would need to change the dialogue too for that.

Cheers for confirming I did not lose my mind. Good luck with project.

[gary-rowe]

Done a code review and it looks good to me. If you choose to make the idiomatic change then it's good to close.

[jim618]

I've reworked things slightly to remove the magic number in the model. This gets rid of the dissonance on the 'Verified' label appearing (or not).

Now when the wallet is created the datestamp is checked and the earliest HD wallet birthday used where appropriate. I've retested this with a missing datestamp and with a valid one ok.

Awaiting review and closing.

[gary-rowe]

Code review looks fine. Will perform final verification later tonight.

[gary-rowe]

I've added a FEST test to ensure we don't regress on this issue since it's on the critical path. The test correctly identified that the new code passed, while earlier code failed.

Verified working so closing.