search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
170 stars 112 forks source link

When a new KeepKey wallet is created 'Trezor' is put as the wallet description #727

Closed jim618 closed 8 years ago

jim618 commented 8 years ago

If you create a new KeepKey wallet 'Trezor' is shown in two places in the Wallet dashboard:

It should either say 'KeepKey' or made generic and 'hardware wallet' used.

gary-rowe commented 8 years ago

This is due to the lack of a KeepKey wallet type in Core which would normally be selected during wallet creation.

jim618 commented 8 years ago

As discussed out-of-channel we have kept WalletType so that it does not differentiate between KeepKey and Trezor.

I have changed the wallet capabilities so that it is agnostic to the brand of hardware device - it just says:

Transactions signed by device
Private keys are held on device
--the BIP 44 path--

Also when a Trezor/KeepKey hard wallet is created the notes field is left blank rather than 'Trezor'. It's only the note so it doesn't matter that it is blank.

The BIP44 soft wallets had a localised bit of text for 'wallet' so has been left unchanged.

I have also renamed some of the WalletManager methods to use 'TrezorClone' rather than 'Trezor' to indicate that it is brand agnostic.

Note that to test you you will have to create NEW wallets as things are set at construction time

Pushed to keep_key branch only.

Awaiting review and closing.

gary-rowe commented 8 years ago

Code review looks good - still requires verification by me.

gary-rowe commented 8 years ago

Verified working. Closing.