Restore menu is remembering KeepKey even when KeepKey removed

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet

https://multibit.org/blog/2017/07/26/multibit-shutdown.html

Other

170 stars 112 forks source link

Restore menu is remembering KeepKey even when KeepKey removed #733

Closed jim618 closed 8 years ago

jim618 commented 8 years ago

I just did the following:

start up MBHD, see password entry screen
plug in KeepKey. The screen transitions to PIN entry screen
start up wallet as normal.
remove keepKey
do switch wallet
password entry screen is shown correctly BUT if you press the 'Restore' button the Restore screen has the first option: "I want to create a new KeepKey wallet" As there is no KeepKey plugged in it should be "I want to create a MultiBit HD wallet".

gary-rowe commented 8 years ago

I've improved the attach/detach handling code so swapping between devices should be seamless in the primary wizards (Welcome and Credentials).

Ready for review and close.

jim618 commented 8 years ago

I just repeated the sequence of events in the OP and still see 'KeepKey' in the list of options (see screen shot) even though the KeepKey has been detached. screen shot 2015-10-10 at 13 30 20

gary-rowe commented 8 years ago

It might be worth re-testing this in light of recent changes made under #745 and #746. I've just followed that exact sequence and all was well.

jim618 commented 8 years ago

KeepKey : retested OP steps - works fine. Trezor : retested OP steps - works fine.

Closing