search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
173 stars 114 forks source link

In Payments a BIP70 Payment request is shown positive, in green. It should be negative, in red #756

Closed jim618 closed 8 years ago

jim618 commented 8 years ago

If a user accepts a BIP70 payment request but does not pay it immediately, it appears in the Payments windows with the type 'They requested'.

This is shown with a positive (green) amount. When it is paid the tx appears as a negative (red) amount.

It would be more consistent if the request was shown as negative in red as someone is asking for you to pay FROM your wallet.

A regular 'created by you' payment request is shown positive and in green.

jim618 commented 8 years ago

Whilst it is in state 'They requested' the number is positive, and shown in green. Once it is paid it is actually a debit from the wallet and is shown correctly in red.

I think I will leave this as is as it is very minor and fixing it is quite likely to add a "x -1" error somewhere.

Will not fix.

Closing.