search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
169 stars 124 forks source link

NPE in savePaymentRequest #798

Closed jim618 closed 8 years ago

jim618 commented 8 years ago 
[2015-10-19T20:55:44.505+08:00] ERROR AWT-EventQueue-0 org.multibit.hd.core.error_reporting.ExceptionHandler - Uncaught exception. Proceeding to show Error Reporting dialog...

java.lang.NullPointerException: null
    at org.multibit.hd.ui.views.wizards.request_bitcoin.RequestBitcoinEnterDetailsPanelView.savePaymentRequest(RequestBitcoinEnterDetailsPanelView.java:245) ~[multibit-hd.jar:na]
    at org.multibit.hd.ui.views.wizards.request_bitcoin.RequestBitcoinEnterDetailsPanelView.beforeHide(RequestBitcoinEnterDetailsPanelView.java:212) ~[multibit-hd.jar:na]
    at org.multibit.hd.ui.views.wizards.AbstractWizard.hide(AbstractWizard.java:226) ~[multibit-hd.jar:na]
    at org.multibit.hd.ui.views.wizards.AbstractWizard$3.actionPerformed(AbstractWizard.java:312) ~[multibit-hd.jar:na]
    at javax.swing.SwingUtilities.notifyAction(Unknown Source) ~[na:1.7.0_80]
    at javax.swing.JComponent.processKeyBinding(Unknown Source) ~[na:1.7.0_80]

Possible race condition during hide.

jim618 commented 8 years ago

Added in null checking on getRate here and in a couple of other places in the code.

Awaiting code review and closing

gary-rowe commented 8 years ago

Verified working. Closing.