search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
169 stars 124 forks source link

Push of data element larger than element in setFiatEquivalent #799

Closed jim618 closed 8 years ago

jim618 commented 8 years ago 
java.lang.RuntimeException: org.bitcoinj.core.ScriptException: Push of data element that is larger than remaining data
    at org.bitcoinj.core.TransactionOutput.toString(TransactionOutput.java:360) ~[multibit-hd.jar:na]
    at org.multibit.hd.core.services.BitcoinNetworkService.setFiatEquivalent(BitcoinNetworkService.java:848) ~[multibit-hd.jar:na]
    at org.multibit.hd.core.services.BitcoinNetworkService.prepareTransaction(BitcoinNetworkService.java:762) ~[multibit-hd.jar:na]
    at org.multibit.hd.ui.views.wizards.send_bitcoin.SendBitcoinWizardModel.prepareTransaction(SendBitcoinWizardModel.java:454) ~[multibit-hd.jar:na]
    at org.multibit.hd.ui.views.wizards.send_bitcoin.SendBitcoinWizardModel.prepareWhenBIP70(SendBitcoinWizardModel.java:920) ~[multibit-hd.jar:na]
    at org.multibit.hd.ui.views.wizards.payments.BIP70PaymentRequestDetailPanelView$1.actionPerformed(BIP70PaymentRequestDetailPanelView.java:280) ~[multibit-hd.jar:na]
    at javax.swing.AbstractButton.fireActionPerformed(Unknown Source) ~[na:1.7.0_80]
    at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source) ~[na:1.7.0_80]
    at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source) ~[na:1.7.0_80]
    at javax.swing.DefaultButtonModel.setPressed(Unknown Source) ~[na:1.7.0_80]
    at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source) ~[na:1.7.0_80]
    at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source) ~[na:1.7.0_80]

Insufficient defensive checking during BIP 70 payment.

jim618 commented 8 years ago

There was a transactionOutput.toString() outside a try- catch. Fixed. Also converted a transactionOutput.toString in logging to log the hash which should always be computable.

Awaiting review and closing

gary-rowe commented 8 years ago

Bouncing back due to missing {} notation - nitpicking I know but consistency is important.

jim618 commented 8 years ago

Updated to use {} notation.

Awaiting review and closing.

gary-rowe commented 8 years ago

Looks good to me. Closing.