search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
169 stars 124 forks source link

Add Buy/Sell wizard with support for Glidera #828

Closed jim618 closed 8 years ago

jim618 commented 8 years ago

Add in support for Buy/Sell bitcoin as per the use case in SpiderOak.

gary-rowe commented 8 years ago

First draft of sidebar UI. See SpiderOak use cases for rationale.

screen shot 2015-12-12 at 17 09 44
gary-rowe commented 8 years ago

First draft of the buy/sell wizard (see glidera branch for implementation):

screen shot 2015-12-12 at 21 06 48
gary-rowe commented 8 years ago

Ready for review, merge and close. See glidera branch.

jim618 commented 8 years ago

Looks good - I had a few comments (by email). Removed 'awaiting review' and popped back to 'bounced back'

gary-rowe commented 8 years ago

Made the changes, and here is a screen shot of the new "spacey" sidebar layout:

screen shot 2015-12-13 at 21 26 24

I've shrunk the Help icon (it was always a bit too large to my eye) and grouped Help and Contacts together since otherwise Contacts would be rather isolated while Help didn't fit naturally with the preferences group below.

Ready for review and close.

jim618 commented 8 years ago

Agreed to group Contacts and Help.

I find the spacing not 'spacey' enough so have tried ThemeAwareTreeCellRenderer with a bigger gap.

Here it is at 25 pixels (rather than 15): 25

And 35: 35

I think 25 looks the best of the three so have committed that.

Other than that I think it works. (The comments by email about sidebar persistence I think we can live with as the alternatives would be poorer.)

Changes made to glidera branch only.

Awaiting review (of updated spacing) and closing.

jim618 commented 8 years ago

It is bikeshedding a bit I know, but on the Buy/sell lightbox there is a bit of visual interference between the 'Visit Glidera' button and the background credit card image. It is the oblongs where the credit card numbers go interfere with the button outline.

As there is only one active element on that lightbox it's a shame it's not clearer. Not a biggie though as the credit card icon works quite well.

jim618 commented 8 years ago

Going through all the FontAwesome icons the credit card one is definitely the best for this action.

gary-rowe commented 8 years ago

Looks fine to me. Closing.