search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
169 stars 124 forks source link

(Russian) Cannot create new Trezor wallet due to UI #837

Closed jim618 closed 8 years ago

jim618 commented 8 years ago

The Russian translations push the buttons off the screen for the Trezor create new wallet operation. You cannot complete the wizard.

Screenshot: screen shot 2016-01-12 at 15 03 31

jim618 commented 8 years ago

Suggest we also check the regular create wallet in Russian as it might have a similar problem

gary-rowe commented 8 years ago

Looks the same as the German one recently (see #773). We need to add a proper wrapper as in other views.

gary-rowe commented 8 years ago

@jim618 can you run through the new FEST tests. You'll see that the Trezor and KeepKey devices have had their UI's translated in error. They are supposed to be partitioned away to avoid being included.

gary-rowe commented 8 years ago

I've adjusted the Trezor and KeepKey components to use HTML wrapping which should allow for correct display over a variety of languages:

screen shot 2016-01-31 at 16 19 38

Unfortunately, I cannot get the title to show in Russian without a small amount of clipping which is annoying.

Please run this up with different languages and explore various screens with lengthy titles to ensure that there is no regression.

Ready for review and close.

jim618 commented 8 years ago

I have created in Russian a Trezor wallet and a soft wallet. All screens looked fine apart from this one:

screen shot 2016-02-01 at 10 49 41

I could still navigate off the screen so it's not fatal.

jim618 commented 8 years ago

Sorry - meant a KeepKey wallet

jim618 commented 8 years ago

Just created a Trezor wallet in German and it all looked good.

gary-rowe commented 8 years ago

This also applied to the Trezor screen (they use the same underlying panel view). I've increased the use of HTML wrapping in labels, especially in status labels so they should wrap much more predictably now across a range of languages (including RTL/LTR).

Here's an example of what to expect:

screen shot 2016-02-01 at 11 27 52

Ready for review and close.

PS I also hardened the handling of a failed device after switching languages and wallet types. Kind of a corner case but the UX was no response to attach/detach of device in the Unlock screen.

jim618 commented 8 years ago

Worked through creating a new Trezor wallet in Russian. All the screens look good. Closing