Closed jim618 closed 8 years ago
I have added separate Buy and Sell buttons and the client_id to the referral URI. The 'buydestinationaddress' is still to do as it is a bit more complex.
The credit card background icon caused some visual interference with the buttons so I have swopped it for a shopping basket. Have a look:
The credit card as background for comparison:
I have added in code so that when the user clicks on the 'Buy bitcoin at Glidera' button a new address is created and added to the Glidera URI. Also a payment request is created and stored with the description 'Buy bitcoin at Glidera'. This then appears in the Payments screen and in Send/Receive.
(It can be deleted in the Payments screen).
The code needs a bit of tidying up (refactor similar code in this wizard and in the RequestBitcoinEnterDetailsPanelView class) and the workflow feels a bit clumsy but it is working.
Awaiting review.
Looks good so far. Would it be worth leaving the credit card symbol in the sidebar and having a basket in the wizard? I know it breaks the continuity but the basket looks too feminine (see #828).
The icon should be the same in the sidebar and wizard - quite confusing otherwise. There were some other payment-ey icons if you want to change it:
https://fortawesome.github.io/Font-Awesome/icons/
p.s. 50% of humanity is female !!
university/ bank might work: http://fortawesome.github.io/Font-Awesome/icon/university/
Fair point on the 50% of humanity, it's just that the shopping basket looks wrong in that position. It took me ages to settle on the credit card image last time. Perhaps change the position of the buttons on the wizard to be horizontally placed rather than vertical - that would mirror the existing Send/Request screen layout.
(So much bike shedding here - sorry)
I've reverted it to credit card icon and adjusted the layout so that the two buttons are horizontal. Pushed.
Tested various combinations and it's all working fine. The new button layout with the consistent credit card iconography works for me:
Closing.
Add referral links for Glidera in format of:
This will need separate Buy and Sell buttons as the Bitcoin address is only on the Buy button