search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
169 stars 124 forks source link

Reduce number of Glidera payment requests created #846

Closed jim618 closed 8 years ago

jim618 commented 8 years ago

Feedback from user testing:

> Would it possible to re-use unused requests on subsequent launches to the Glidera website? I think this would be cleaner

This would probably entail adding more state to the persisted payment requests as we currently don't track that it is for use by Glidera

jim618 commented 8 years ago

I've added a boolean to the MultiBit HD payment request so that the 'created for Glidera' addresses are marked as such. This is persisted.

When a user presses the 'Buy bitcoin at Glidera' button the list of extant payment requests are subset by: 1) Created for Glidera ? 2) No transactions sent to this address ?

If an address is available it is reused (i.e. put on the Glidera URL but no new payment request created)

I have regression tested on older MBHD code, which loads the payment requests fine. It nukes any existing values when it writes out. Then a new version of MBHD will create ONE (only) new payment request. This is fine.

Awaiting review and closing

gary-rowe commented 8 years ago

Verified working and code review looks fine.

Closing.

jim618 commented 8 years ago

I have reopened this as I have modified the code slightly and it needs re-review.

Change: When a Glidera address is reused there is no need to save a payment request (you just checked that there was one free) so I have modified the code to honour this.

This will save time and IO.

Awaiting review and closing.

gary-rowe commented 8 years ago

Verified working. Closing.