search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
169 stars 124 forks source link

Check for NODE_BLOOM service bit #871

Closed jim618 closed 7 years ago

jim618 commented 8 years ago

From the Bitcoin Core v0.12.0 release notes (https://github.com/bitcoin/bitcoin/blob/v0.12.0/doc/release-notes.md):

NODE_BLOOM service bit

Support for the NODE_BLOOM service bit, as described in BIP 111, has been added to the P2P protocol code.

BIP 111 defines a service bit to allow peers to advertise that they support bloom filters (such as used by SPV clients) explicitly. It also bumps the protocol version to allow peers to identify old nodes which allow bloom filtering of the connection despite lacking the new service bit.

In this version, it is only enforced for peers that send protocol versions >=70011. For the next major version it is planned that this restriction will be removed. It is recommended to update SPV clients to check for the NODE_BLOOM service bit for nodes that report versions newer than 70011.

Nodes can switch off their bloom support if they want to so this should be checked before a bloom filter is set. This would be in bitcoinj but I'll raise it here for now.

kliyer commented 7 years ago

Check for bloom filter support (BIP 111) added in release https://github.com/keepkey/multibit-hd/releases/tag/0.4.1