Closed gary-rowe closed 9 years ago
Download buttons now wait for 5s before redirecting the page to the appropriate "how to install" page. These have been checked on FF, Chrome, IE and Safari on Win and OS X. The NoScript version just has a simple link under the buttons.
This issue must be verified to work on an independent machine since the download operation is mission critical.
Missed out the redirect code for the primary use case. To verify ensure browser is closed and restarted between page checks. Expected behaviour is:
Ready for review and close.
Safari Test Results I started up Safari and navigated to http://localhost:8888 The buttons are already enabled and there is no Accept toolbar. (Note I will have run up this site and clicked the Accept button YESTERDAY). Java script is enabled.
Clicking on each of the Windows, Linux, Mac buttons initiates the downloads and, after a few seconds, transitions to the appropriate Install page.
Checked with NoScript that links appear and navigate to the correct page.
Firefox Test Results. Start with javascript enabled. Navigate to http://localhost:8888 See the 'Accept bar' ok. Download buttons not enabled. Click accept. Download buttons enabled. 'Accept bar' disappears. Click each of the Download buttons in turn. Each correctly offers a 'Save/Run' dialog, downloads the binary and transitions to the install page ok.
With javascript disabled the simple 'how to install' links all appear and work correctly
Chrome Test Results Open Chrome and navigate to http://localhost:8888 See Download buttons disabled and 'Accept bar'. Click accept. Alert bar disappears and Download buttons enabled. Clicking each of the Download button in turn downloads the correct binary and, after a few seconds, navigates to the correct install page
Internet Explorer Test Results I am testing only on a Mac so haven't tested IE.
Opera Test Results. Open Opera and navigate to localhost:8888 See disabled Download buttons and Accept bar. Click Accept. Accept bar disappears and Download buttons enable. Click on each download button in turn. Each downloads the correct binary and traverses to Install page ok. Turn off Javascript. See the Install links which work ok. Check the Download buttons download the cirrect binary.
tl;dr Other than (most likely a cache issue) the Accept/Download works fine on Safari/Chrome/Firefox/Opera. IE not checked.
OK. That's a good set of tests. I've verified it against IE 11 on Windows 8 and the JavaScript is absolutely vanilla.
Closing.
Require supporting links for the download buttons providing "How to install" information. Since there is quite a lot of additional info to convey this is best handled by the OS-specific pages.
In JavaScript this can be initiated with a timed redirect after the download has begun. In NoScript this will have to be a static link beneath the buttons.
The "How to install" page should contain: