search

Multibit-Legacy / multibit-website-legacy

Website for multibit.org
Other
12 stars 25 forks source link

Font Awesome not loading under NoScript #217

Closed jim618 closed 9 years ago

jim618 commented 9 years ago

Posted in MBHD repo by @wodry

https://github.com/bitcoin-solutions/multibit-hd/issues/617

Inline copy:

When visiting https://multibit.org, on the right side the bullets of the list "Why choose MultiBit HD ?" are shown as strange symbols, see screenshot.

Environment: Debian Jessie 64 Bit Iceweasel 31.7.0 NoScript Extension that blocks javascript from multibit.org, ajax.googleapis.com, bootstrapcdn.com and fonts from fonts.gstatic.com and maxcdn.bootstrapcdn.com etc. Using Proxy privoxy

A good website should work without (third party) JavaScript, fonts etc., IMHO.

multibithd

gary-rowe commented 9 years ago

Yeah, this is a side-effect of NoScript preventing Font Awesome from being downloaded.

I'll replace the FA icons with bullets for maximum compliance with NoScript browsers.

gary-rowe commented 9 years ago

I've modified the NoScript behaviour to ensure the list style is suitable. It's slightly different to the JS enabled version but looks fine in situ:

screen shot 2015-06-18 at 22 06 39

This has been updated for the FR and JA locales.

Ready for review and close.

ghost commented 9 years ago

Your link http://localhost:8888/fr/index.html does not work for me, of course. So I am wondering how to review. I checked https://multibit.org/fr/index.html but there is still the issue, see screenshot. multibithd

gary-rowe commented 9 years ago

Hi @wodry. Yeah, those links are for localhost:8888 when running the website locally. It's a very similar process to running MultiBit HD from within the IDE as you've done before.

Instructions are in the README: https://github.com/bitcoin-solutions/multibit-website/blob/develop/README.md

ghost commented 9 years ago

Please someone else build the website and review. I already retired from my layman beta tester dev role :)

jim618 commented 9 years ago

I'll do it. :-)

jim618 commented 9 years ago

Checked by disabling javascript (Safari, Mac) and see bullets. Closing.