Multiplicom / axiom

3 stars 0 forks source link

possible html building mishaps after upgrade to jQuery 3.5 #87

Closed MichaelVyverman closed 3 years ago

MichaelVyverman commented 3 years ago

:bug: Description

After update of the requirements to jQuery 3.5, it was noted that some html documents provide strange output. This is related to a new behaviour in the updated jQuery related to a security bug. See the followings link for more information:

:x: Actual Behavior

jQuery has become more strict resulting in different behaviour if auto-closing html tags are used for tags that do not support it. For example, in the docs font-awesome icons are often implemented as <i class="fa fa-something" />, but the <i> tag is not auto-closing. The new behaviour of jQuery somehow copies the tag at multiple places. This is 1 example of the error.

:white_check_mark: Expected Behavior

jQuery expects correct use of tags. The only auto-closing are area|br|col|embed|hr|img|input|link|meta|param

:bulb: Possible Fix

Go through the code and fix all instances