Multiscale-Genomics / mg-dm-api

API for the management of file locations and users within the MuG VRE
Apache License 2.0
0 stars 2 forks source link

"source_id" parameter #6

Closed marcopasi closed 7 years ago

marcopasi commented 7 years ago

The method parameter corresponding to the "source_id" entry in the file object should be named "source_id" for consistency. This is the case for all methods except "dmp.set_file", where it is "source" (https://github.com/Multiscale-Genomics/mg-dm-api/blob/master/dmp/dmp.py#L391):

[...]
def set_file(self, user_id, file_path, file_type = "", data_type = "", taxon_id = "", compressed=None, source = [], meta_data = {}, **kwargs):
[...] 

I propose to change it to "source_id".

markmcdowall commented 7 years ago

I have added this to the code