Multiverse / Multiverse-Core

The original Bukkit Multi-World Plugin!
BSD 3-Clause "New" or "Revised" License
949 stars 299 forks source link

GTNH modpack interaction, MV-Core not generating GT veins. #1935

Closed plaguewolf closed 5 years ago

plaguewolf commented 6 years ago

Firstly: https://github.com/GTNewHorizons/NewHorizons/issues/3631

further down the page is a note about the segment of code that is causing the problem. worth noting is that a simple fix would be to somehow denote MV created worlds as being "overworld" to the world provider to get around

if (!((aWorld.provider.getDimensionName().equalsIgnoreCase("Overworld")) ...

at least i think thats how that works... not very good with java, just enough to get the gist. anything you can do about this?

fernferret commented 5 years ago

Thank you for linking your other issue. I have no promises on this one but I'm just commenting here to let you know it's been read. I'm not sure at this time if this is something I can do anything about because as stated in the other thread, It's a mess to keep everything going. I can't put in anything that could compromise a standard Vanilla experience and string parsing on the dimension name seems... not great.

If there were an enum that would make me feel comfortable, if someone wants to submit a PR for this (taking into account that I don't want to put a hack in with string names of dimensions), I'd be willing to look at it but I don't see myself having time to look at this.