[Bug]: Cannot use mvtp commands when player has a passenger

lucian929 commented 2 years ago

`/mv version -p` output

https://paste.gg/p/anonymous/a5de4454e1714fd8b60f8532ae22dc0a

Server logs

https://mcpaste.io/fcd0177c1939ad48

Server Version

[02:40:23 INFO]: This server is running Pufferfish version git-Pufferfish-11 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 1e9de23 on HEAD)
You are on the latest version!
Previous version: git-Airplane-103 (MC: 1.17.1)

Bug Description

When a player has a passenger attached, they cannot teleport to different worlds using multiverse. I was able to teleport using other plugins (like essentials where I had a home inside of a separate world).

Steps to reproduce

Start your server
Attach a passenger to the player (using the method linked above)
Attempt to use /mv tp <world> or /mvtp <world.
Notice no errors in console, no errors in debug messages, however you do not switch worlds.

Agreements

[X] I have searched for and ensured there isn't already an open or resolved issue(s) regarding this.
[X] I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

lucian929 commented 2 years ago

This was also tested on Paper:

[21:50:07 INFO]: This server is running Paper version git-Paper-380 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: f8992ee)
You are 1 version(s) behind
Download the new version at: https://papermc.io/downloads
Previous version: git-Airplane-103 (MC: 1.17.1)

benwoo1110 commented 2 years ago

Test with only mv-core installed.

lucian929 commented 2 years ago

That can't be done because you need to have a plugin to apply a passenger to the player.

lucian929 commented 2 years ago

Same issue on a server with only MV core and a plugin to spawn the passenger: https://mcpaste.io/09122fa09dfab135

AnonymousBluejay commented 2 years ago

I can confirm this issue, the same thing happens with multiverse portals.

Player#teleport() just does not work when the player has a passenger, with papermc at least.

This can probably be fixed by ejecting the passenger before teleporting the player and then adding the passengers back after the teleport.

Multiverse / Multiverse-Core