[Bug]: Multiverse overriding external PlayerSpawnLocationEvent

kyngs commented 2 years ago

`/mv version -p` output

Server logs

https://paste.gg/p/anonymous/fda5f5bb8f374f4abce5a3e0ddcff1e5

Server Version

[14:33:42 INFO]: Checking version, please wait...
[14:33:42 INFO]: This server is running Paper version git-Paper-155 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 99cf01f)
You are running the latest version
Previous version: git-Paper-82 (MC: 1.18.1)

Bug Description

Please take look here: https://github.com/PaperMC/Paper/issues/7361. I have isolated the issue to Multiverse-Core

Steps to reproduce

Please take look here: https://github.com/PaperMC/Paper/issues/7361

Agreements

[x] I have searched for and ensured there isn't already an open or resolved issue(s) regarding this.
[X] I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

kyngs commented 2 years ago

So this can be changed in the config, tho I still believe that the mechanism shouldn't be placed in PlayerJoinEvent, but in PlayerSpawnLocationEvent. And possibly even with low priority, so it can be overridden by other plugins.

benwoo1110 commented 2 years ago

I recall that PlayerSpawnLocationEvent may not be available on craftbukkit, not sure if it's on 1.13 as well. So breaking change may be needed to implement this.

kyngs commented 2 years ago

I am sure it can, if you turn off the override-spawn-location option in the config (which is the default on), the problem stops appearing. Maybe put it to a bit lower priority, so it still can be overridden?

benwoo1110 commented 2 years ago

I'm not talking about config option or priority, I'm referring to bukkit api version support for that event method.

Multiverse / Multiverse-Core