search

Multiverse / Multiverse-Inventories

BSD 3-Clause "New" or "Revised" License
93 stars 82 forks source link

Inventories causing crashes when a player tries to teleport #463

Open trickman325 opened 3 years ago

trickman325 commented 3 years ago

Running paper 1.17.1 - 112 with Multiverse-inventories 4.2.2 and Lands 5.12.1

When a player tries to teleport every so often with /lands teleport it crashes the server

This is the log from the most recent crash 2021-07-21-2.log

Ive contacted the Lands dev and there is nothing he can do as it is Inventories and paper related not his side of things.

Really need to get this sorted as its casing issues when even when the server isnt stressed

benwoo1110 commented 3 years ago

[21:20:19] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 5001ms or 100 ticks behind

this warning was shown around 5 to 10 times before the crash. Likely your server is just lagging and just nice it timed out at mvinv operations.

trickman325 commented 3 years ago

@benwoo1110 That lag was over an hour before the crash. There was only 5 people on the server when it crashed and it was caused by the command running which you can see in that log at the bottom.

Here are other logs that are the exact same issue after restarts. 2021-07-20-3.log 2021-07-20-2.log

This was also what the Lands dev Angeschossen had to say about it

benwoo1110 commented 3 years ago

Looks like this issue is specific to only when teleport is done by land plugin. Using essentials teleport commands or mvtp doesnt result in such as issue from my testing. As such I will need a link to their plugin and hope it's not behind closed doors.

trickman325 commented 3 years ago

@benwoo1110

this is the plug-in https://www.spigotmc.org/resources/lands-land-claim-plugin-grief-prevention-protection-gui-management-nations-wars-1-17-support.53313/

trickman325 commented 3 years ago

@benwoo1110 any news on this??? This is becoming a major issue for my server :/

benwoo1110 commented 3 years ago

Lands is behind paid walls, so very hard for me to have anything to work off.

trickman325 commented 3 years ago

I've contacted Angeschossen and am waiting a response to hopefully give you access

Angeschossen commented 3 years ago

If you could send me your spigot account, I could give you access to the download.

Lands pre-loads the destination chunk via the chunk tickets before teleporting to the destination. After the teleportation is done, it will release the chunk again. I've made sure that synchronization is enforced at the usage of the chunk tickets. Also the issue is only existent on paper and their forks.

trickman325 commented 3 years ago

@benwoo1110 ^^

nicegamer7 commented 3 years ago

ben will be busy this week, so I'll try to take a look. My spigot username is nicegamer7 and ben's is benji_0224.

trickman325 commented 3 years ago

@Angeschossen ^^

Angeschossen commented 3 years ago

ben will be busy this week, so I'll try to take a look. My spigot username is nicegamer7 and ben's is benji_0224.

Added both.

trickman325 commented 3 years ago

Lands.zip Multiverse-Core.zip Multiverse-Inventories.zip

These are my files in which this error happened @nicegamer7 @benwoo1110

Angeschossen commented 3 years ago

This ticket can be closed. We found a solution.

benwoo1110 commented 3 years ago

So it was a bug on your end?

Angeschossen commented 3 years ago

It looks like it's a problem with the combination paper + chunk plugin tickets or I did something wrong on my end. I just changed the way how the teleportation works without using chunk plugin tickets. Issue resolved.

Although the server would only crash at using paper and multiverse-inventories installed.

benwoo1110 commented 3 years ago

Glad to hear that it's fixed... but very interesting why mv-inv specifically tho, sadly I have no time to debug Minecraft things atm

nicegamer7 commented 3 years ago

Quite strange, yeah. You might want to report this issue to Paper, since you said it only happens with Paper. I don't think MV does anything out of the ordinary regarding chunks.

SiuanSong commented 3 years ago

I seem to be having a similar thing happening but with AreaShop plugin. https://gist.github.com/SiuanSong/5bfdfaec6f7e007e28a43f6ec30cccc9 https://gist.github.com/SiuanSong/2ba894928dee36acdefe4da0e37d1a59 https://gist.github.com/SiuanSong/8f9c8dc1aa3893587f104859f88198c6

Also seems to have been triggered just by using /gmc from essentials https://gist.github.com/SiuanSong/1b620c2000c9372d8e7ee14e41750775