search

Multiverse / Multiverse-Inventories

BSD 3-Clause "New" or "Revised" License
95 stars 82 forks source link

Incompatibility with Super Vanish #468

Open slvlr opened 3 years ago

slvlr commented 3 years ago
  1. When linking files, do not attach them to the post! Copy and paste any logs into https://gist.github.com/ or other similar service.

Information

Help request

Problem Multiverse inventories has a compatibility issue with Super Vanish https://www.spigotmc.org/resources/supervanish-be-invisible.1331/ If you try to open a chest in vanish, it switches your gamemode to spectator to be able to open the chest. if MV inventories is installed. Your inventory will flash but not change, and then close the container opened immediately. The Dev of Super Vanish doesn't think he can fix this. Is this something that you would be a able to add compatibility for?

What I have tried Uninstalling Multiverse inventories. Supervanish worked fine.

nicegamer7 commented 3 years ago

The developer of SuperVanish can most likely fix this by cancelling the GameModeChangeShareHandlingEvent when needed.

benwoo1110 commented 3 years ago

Maybeee this https://github.com/Multiverse/Multiverse-Inventories/pull/459 will help?

slvlr commented 3 years ago

The developer of SuperVanish can most likely fix this by cancelling the GameModeChangeShareHandlingEvent when needed.

The SV dev says the way silent open chest works is that it temporarily puts you into spectator mode so the server doesn't send the opening sound an animation. If you have separate inventories for spectator mode then that causes issues. It's already such a messy solution though, if I mess with the GameModeChangeShareHandlingEvent as well it would probably cause more issues than it solves. Is there no option to exempt spectator mode from having separate inventories - if not can this be added?

benwoo1110 commented 3 years ago

Test with: Multiverse-Inventories-4.2.3-SNAPSHOT.zip

slvlr commented 3 years ago

Test with: Multiverse-Inventories-4.2.3-SNAPSHOT.zip

What have you changed in this build. Have you changed it so spectator has a separate inventory, or attempted to fix my issue another way?

benwoo1110 commented 3 years ago

Basically #459: dont do inv change if changing to spectator mode since spectator mode shouldn't have inv anyways. I dont have time to go into code details rn.

nicegamer7 commented 3 years ago

I believe ben's solution is better than the one I came up with.