Closed benwoo1110 closed 3 years ago
Is the permission check used anywhere?
Do you mean for getPortal
method? It is used in PlayerMoveEvent as well
Or do you mean if permission is checked later on in the PlayerPortalEvent? 😅
Yeah I mean getPortal
with the permission check.
My question is: Is there any use for checking permission in getPortal
?
In events such as PlayerBucketFillEvent
, it looks like it's useful there. Bcu only ppl with access perms should be able to change its fill
Ah okay, sounds good then.
Oh btw this fix will only work when you combine it with fix from #584. But can merge this first
See my comments at https://github.com/Multiverse/Multiverse-Portals/pull/584#issuecomment-831842373