search

Multivit4min / TS3-NodeJS-Library

TeamSpeak 3 Server Query Library supports SSH and RAW Query
https://multivit4min.github.io/TS3-NodeJS-Library/
MIT License
149 stars 20 forks source link

Parsing of TeamSpeak data. #135

Closed Pantoflarz closed 4 years ago

Pantoflarz commented 4 years ago

Describe the bug At the moment, some of the response types returned by the class seem odd.

This is clearly visible in https://github.com/Multivit4min/TS3-NodeJS-Library/blob/master/src/types/ResponseTypes.ts

Where things like clid, clientDatabaseId and cid are defined as strings.

I was wondering if theres any particular reason why that is the case, considering it would make far more sense to have them as numbers?

To Reproduce N/A

Expected behavior The response types should be more logical - for example, things like clid, clientDatabaseId or cid should be numbers, not strings.

Versions used

Additional context N/A

Pantoflarz commented 4 years ago

Realised that this is in fact, a feature related to TeamSpeak 5.

My apologies.

Multivit4min commented 4 years ago

I need to say tough that this is only that what i saw what happened on Sinusbot, I cant tell for 100% that this happens with the query aswell, but I did this just to be prepared