search

MulverineX / premid-powercord

Gives you the abilty to use premid when you launch discord without installing and running the external bloated electron tray process for an overweight IPC-Websocket bridge
MIT License
22 stars 3 forks source link

URL Image key & other obscure data causing intermittent crashes (and crash-loops) #5

Open xirpy opened 2 years ago

xirpy commented 2 years ago

Mangadex & others crash the client and send it into a crash loop until you reset the extension.

MulverineX commented 2 years ago

In my experience it enters a crash loop if: a. premid is active on a site before you start discord b. discord crashes from other means while premid is active

Both of these are relatively avoidable, to fix it when it happens you must kill all discord processes, disable the premid extension, close sites that are causing activity, enable the premid extension, start discord, then continue as normal. I have no idea how to fix this as with Powercord's current setup it is impossible to debug hard crashes like these, even the shell console does not provide enough information. I would recommend removing unstable plugins and if you use inspect element and it crashes to reinstall discord (remove all residual installation files too).

xirpy commented 2 years ago

i tried this but still doesn't worked :/ it crash even if i'm not using any website's presence

kill all discord processes, disable the premid extension, close sites that are causing activity, enable the premid extension, start discord, then continue as normal

MulverineX commented 2 years ago

You disabled the extension?

xirpy commented 2 years ago

yeah, it worked now, it doesn't crash, but as soon i open an website that has a presence, it crash

  1. Not having any website that uses the presences open
  2. disable and enable the extension
  3. Start Discord and go to the website Crash
MulverineX commented 2 years ago

That's super weird, I've never experienced that behavior. Are you using the latest PreMiD?

xirpy commented 2 years ago

Lol, reinstalled the extension and it's working now (uninstalled and installed from the Chrome Extensions store again), weird, i thought Chrome automatically update the extension

edit1, i know why it's crashing, it's because of Mangadex presence, and others i don't remember well, but looks like it's because of that, youtube works fine (showing the presence normally)

MulverineX commented 2 years ago

well if those work with the premid app then its a bug. a pain in the ass, but a bug. Thanks for the report, I'll look into it. You can either not use those presences or use the app for now.

xirpy commented 2 years ago

Also, wanted to know, will presence thumbnail support be added? (since it also crash if i try to enable lol, Youtube presence)

BlackOfWorld commented 2 years ago

Crashes for me too. Extension is latest and site is SoundCloud.

MulverineX commented 2 years ago

This should be in a separate issue, #7

MulverineX commented 2 years ago

uhhh actually no. I should've tested this first: image

@Shironep @BlackOfWorld No idea why your clients are crashing... it works fine for me.

MulverineX commented 2 years ago

Hmmm, thumbnails aren't on by default for the youtube presence, and when I changed my setting in premid to enable them the client crashed 🤔. It started working again when I restarted the client though. Now I can't even reproduce this exact behavior, but I'm having issues when switching between URL and no URL... I hate how hard it is to debug this crap.