search

MunchDev / EpidemicVisualiser

MIT License
1 stars 0 forks source link

[BUG] Issue with Linear Scale Graph #20

Closed aaronleaa closed 4 years ago

aaronleaa commented 4 years ago

When using Linear scales, the graph lines of some countries do not appear on the plotted graph

Expected Behavior

Graph lines of all countries should appear on the graph

Current Behavior

Graph lines for some countries do not appear on the graph

Possible Solution

Check linear scale code for possible errors

Steps to Reproduce

  1. Run console-application.py, World tally plot mode
  2. Countries inputted (Singapore, Malaysia, Qatar, China, US) in order
  3. Date inputted (04-05-2020)
  4. Timespan (40 Days)
  5. Plot scale (linear)
  6. Plot type (cdra)

Context (Environment)

The issue caused some of the graph lines of some countries to not appear, which affects the overall world tally graph.

Detailed Description

Trying to plot graphs between countries that have a large number of COVID-19 cases and a low number of COVID-19 cases would cause some graph lines to not display correctly.

Possible Implementation

N/A

image [Image: Singapore graph line not showing]

image [Image: Singapore and Malaysia graph line not showing]

image [Image: Singapore graph line not showing]

image [Image: Singapore and Malaysia graph line not showing]

MunchDev commented 4 years ago

Noted and will work on it.

MunchDev commented 4 years ago

Just a gentle reminder, please also report your branch and HEAD refs.

MunchDev commented 4 years ago

Errors reproduced successfully, attaching debugger...

MunchDev commented 4 years ago

Errors persist when calling function plot_tally directly.

MunchDev commented 4 years ago

Tested with different countries, the error seems to be due to the render of the plot itself. When trying to use country = [“Singapore”, “Malaysia”, “China”, “US”], Singapore is still visible although the scale is very big. However, when plotted together with Qatar on that scale, Qatar is just a bit higher than Singapore, and as it is plotted after Singapore (as in the order), the plot will be placed in front.

MunchDev commented 4 years ago

So this is an external render error with matplotlib. No further action is taken. Case closed!