Mundocani / Outfitter

Outfitter addon for World of Warcraft
MIT License
1 stars 11 forks source link

Classic Support #1

Open karai17 opened 4 years ago

karai17 commented 4 years ago

Are there any plans to support WoW Classic (v1.13.2)?

patnodewf commented 4 years ago

I get the following error with version 1.4 (TOC 11200), which worked for wow "vanilla" client 1.12:

Error occured in: Global Count: 1 Message: ..\AddOns\Outfitter\Outfitter.lua line 563: attempt to call global 'TEXT' (a nil value) Debug: [C]: TEXT() Outfitter\Outfitter.lua:563: in main chunk Locals:

That's this snippet from the Outfitter.lua: StaticPopupDialogs["OUTFITTER_CONFIRM_DELETE"] = { text = TEXT(Outfitter_cConfirmDeleteMsg), button1 = TEXT(DELETE), button2 = TEXT(CANCEL), OnAccept = function() Outfitter_DeleteSelectedOutfit(); end, timeout = 0, whileDead = 1, hideOnEscape = 1 };

patnodewf commented 4 years ago

changing TEXT to loadstring results in this:

Error occured in: Global Count: 1 Message: [string "OutfitterItem0OutfitMenu:OnLoad"] line 1: attempt to index global 'this' (a nil value) Debug: [C]: ? [string "*:OnLoad"]:1: [string "*:OnLoad"]:1

This appears to be in the XML file. I have no experience with how addons are made, though - I'm just trying to interpret the syntax.

rothomp3 commented 4 years ago

The Classic client is actually branched from the current retail one, so we're more likely to have luck running the current version than the old 1.12-compatible version. I haven't tried it yet, will do so soon.