Munich-Quantum-Software-Stack / QDMI

Quantum Device Management Interface (QDMI)
https://munich-quantum-software-stack.github.io/QDMI/
Apache License 2.0
21 stars 0 forks source link

Generated template needs additional files #91

Closed denialhaag closed 3 hours ago

denialhaag commented 5 hours ago

I wanted to report a few issues I ran into when working with the generated device template.

One currently has to manually add a number of additional files for the project to compile:

Futhermore, one has to edit the root CMakeLists.txt to add the following lines:

# set some important directories
set(QDMI_INCLUDE_BUILD_DIR
    "${CMAKE_CURRENT_SOURCE_DIR}/include"
    CACHE INTERNAL "Include directory")
set(QDMI_TEST_DIR
    "${CMAKE_CURRENT_SOURCE_DIR}/test"
    CACHE INTERNAL "Test directory")
set(QDMI_CMAKE_DIR
    "${CMAKE_CURRENT_SOURCE_DIR}/cmake"
    CACHE INTERNAL "CMake directory")
ystade commented 4 hours ago

Thanks you @denialhaag for bringingin up this issue. Unfortunately, I cannot reproduce the problem on my machine.

We just merged a new PR #90 that add an extensive explanation of the usage of the templates Could you please read thorugh those steps and check whether they resolve your problem. If the problem persists, could you please detail the steps until you encountered the issue such that it is easier for us to figure out what happened there?

Thank you so much for your collaboration!

denialhaag commented 3 hours ago

My bad, I pulled QDMI, cretaed a new template, and it worked like a charm. Maybe it was related to the pinned revision. 🤔

burgholzer commented 3 hours ago

My bad, I pulled QDMI, cretaed a new template, and it worked like a charm. Maybe it was related to the pinned revision. 🤔

That could very much be it. We adjusted that part in the latest PR. Going to close this for now. Feel free to reopen if any problems still arise.