Closed pysan3 closed 8 months ago
Looks like this is breaking multiple tests.
You can run the tests locally using: ./scripts/test.sh
I see those tests failing even without my changes, so I doubt those failures are on me.
Besides, 78 tests for nui.split
do pass, which is the only file I changed, and I don't think my change will affect other files.
Hmm, I only get test errors on nvim-nightly, and a nightly that's published at least within a week. Nvim-stable works as well.
Working nvim version.
NVIM v0.10.0-dev-2129+gba9f86a9c
Build type: RelWithDebInfo
LuaJIT 2.1.1703358377
Run "nvim -V1 -v" for more info
Not working nvim version.
Can you reproduce the error with the very latest nvim-nightly @MunifTanjim ?
Seems like this is the PR that should've made things easier, but now backfiring your carefully crafted test suites. I'm not sure tho.
Fix proposed at https://github.com/MunifTanjim/nui.nvim/pull/333
Could you check it out @MunifTanjim ?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e561ac5
) 99.04% compared to head (4f6b07e
) 99.04%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the fix 🚀
Glad to see the ✅ again :)
Thanks!
reference: https://github.com/MunifTanjim/nui.nvim/pull/197
The exact same thing (multiple hidden splits point to the same bufnr) can happen to
NuiSplit
as well.I get the error message: `Invalid 'group': 'nuihide'` when I try to
split:show()
.Hope this gets merged as soon as possible :)
Thanks in advance.