MunifTanjim / nui.nvim

UI Component Library for Neovim.
MIT License
1.62k stars 57 forks source link

fix(ci): fix tests using old nvim api #333

Closed pysan3 closed 8 months ago

pysan3 commented 8 months ago

vim.api.nvim_win_get_config used to return a dict of numbers to represent a vim float number for row and col fields. This behavior was fixed in https://github.com/neovim/neovim/pull/27284 as a breaking change to the old API without any notice. Now user can refer to the value of config.row without indexing like config.row[vim.val_idx].

This is the reason why tests are failing in https://github.com/MunifTanjim/nui.nvim/pull/332.

pysan3 commented 8 months ago

Haha, devs are soo bad at writing docs lol.

image

This is the only mention in the docs referring to this breaking change.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (35da9ca) 99.04% compared to head (9f7c5ff) 99.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #333 +/- ## ======================================= Coverage 99.04% 99.04% ======================================= Files 20 20 Lines 2725 2725 ======================================= Hits 2699 2699 Misses 26 26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MunifTanjim commented 8 months ago

Thanks for looking into it 🙌🏼