Munksgaard / session-types

MIT License
550 stars 21 forks source link

Handle some of the reported by clippy #41

Closed laumann closed 6 years ago

laumann commented 6 years ago

Fixes #37

laumann commented 6 years ago

clippy complained about complicated types and suggests type aliases, but long types are kind of inevitable with this library, so I haven't changed those.

laumann commented 6 years ago

I also ignored the many_single_char_names lint. In the planeclip example there are quite a few single-letter variables (up to eight?), but it's okay I think.

Munksgaard commented 6 years ago

I also ignored the many_single_char_names lint. In the planeclip example there are quite a few single-letter variables (up to eight?), but it's okay I think.

Is it possible to add some annotations or options in the Cargo.toml to silence those warnings?

Good work by the way!

laumann commented 6 years ago

Is it possible to add some annotations or options in the Cargo.toml to silence those warnings?

I added cfg_attr in the right places to ignore some lints. But it'd be nice if clippy.toml could be used to list allow/warn/deny levels for specific lints.

Munksgaard commented 6 years ago

Looks good :+1:

laumann commented 6 years ago

I can merge?

Munksgaard commented 6 years ago

Yeah, go ahead :)