search

Munksgaard / session-types

MIT License
550 stars 21 forks source link

Clean up dependencies #46

Closed Munksgaard closed 5 years ago

Munksgaard commented 5 years ago

compiletest should be a dev dependency and it is also not a requirement for chan_select to work.

Munksgaard commented 5 years ago

The tests fail because we're running them on stable/beta, and compiletest doesn't currently compile on stable/beta.

Edit: At least not without the --features stable flag. It builds with that feature set, so I guess we have to amend our .travis.yml to support that. However, it does seem like the tests in compiletest fail to run on stable with the following message:

$ RUST_BACKTRACE=1 rustup run stable cargo test --features stable 
    Finished dev [unoptimized + debuginfo] target(s) in 0.05s
     Running target/debug/deps/compiletest_rs-a76f8b6231037bed
thread 'main' panicked at 'No option 'nocapture' defined', /home/munksgaard/.cargo/registry/src/github.com-1ecc6299db9ec823/getopts-0.2.18/src/lib.rs:746:21
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::print
             at libstd/sys_common/backtrace.rs:71
             at libstd/sys_common/backtrace.rs:59
   2: std::panicking::default_hook::{{closure}}
             at libstd/panicking.rs:211
   3: std::panicking::default_hook
             at libstd/panicking.rs:227
   4: std::panicking::rust_panic_with_hook
             at libstd/panicking.rs:511
   5: std::panicking::continue_panic_fmt
             at libstd/panicking.rs:426
   6: std::panicking::begin_panic_fmt
             at libstd/panicking.rs:413
   7: getopts::Matches::opt_vals
             at /home/munksgaard/.cargo/registry/src/github.com-1ecc6299db9ec823/getopts-0.2.18/src/lib.rs:746
   8: getopts::Matches::opt_present
             at /home/munksgaard/.cargo/registry/src/github.com-1ecc6299db9ec823/getopts-0.2.18/src/lib.rs:760
   9: test::parse_opts
             at /home/munksgaard/.cargo/registry/src/github.com-1ecc6299db9ec823/tester-0.4.1/src/lib.rs:553
  10: test::test_main
             at /home/munksgaard/.cargo/registry/src/github.com-1ecc6299db9ec823/tester-0.4.1/src/lib.rs:255
  11: test::test_main_static
             at /home/munksgaard/.cargo/registry/src/github.com-1ecc6299db9ec823/tester-0.4.1/src/lib.rs:309
  12: compiletest_rs::__test::main
             at src/lib.rs:1
  13: std::rt::lang_start::{{closure}}
             at /checkout/src/libstd/rt.rs:74
  14: std::panicking::try::do_call
             at libstd/rt.rs:59
             at libstd/panicking.rs:310
  15: __rust_maybe_catch_panic
             at libpanic_unwind/lib.rs:105
  16: std::rt::lang_start_internal
             at libstd/panicking.rs:289
             at libstd/panic.rs:392
             at libstd/rt.rs:58
  17: std::rt::lang_start
             at /checkout/src/libstd/rt.rs:74
  18: main
  19: __libc_start_main
  20: _start
error: test failed, to rerun pass '--lib'