Munkwolf / dcs-community-keybinds

A collection of keybinds for DCS.
93 stars 28 forks source link

UH-1H: Wrong value_up for 'Landing Light Switch..(2-way Switch)' keybinds #30

Closed correca closed 2 years ago

correca commented 2 years ago

Hi, in order to work fine I changed value_up value for those '2-way Switch' keybinds

    -- Collective

    {down = device_commands.Button_7, up = device_commands.Button_7, cockpit_device_id = devices.NAVLIGHT_SYSTEM, value_down = 1, value_up = -1, name = _('Landing Light Control Switch Extend else Off (2-way Switch)'), category = {_('Ins Collective Stick'), _('Custom')}},
    {down = device_commands.Button_7, up = device_commands.Button_7, cockpit_device_id = devices.NAVLIGHT_SYSTEM, value_down = -1, value_up = 1, name = _('Landing Light Control Switch Retract else Off (2-way Switch)'), category = {_('Ins Collective Stick'), _('Custom')}},
correca commented 2 years ago

I am closing the issue because I just realized that you are already working on this issue. Thank you for everything.

correca commented 2 years ago

Sorry, this issue is still open

Munkwolf commented 2 years ago

I added the search light commands in a recent commit, and the above landing light commands as an alternate. They'll be a part of the next release after I work through some other updates.

The landing light is a 3-way switch, and the commands I originally added work as a 3-way, with the up actions returning the switch to the off position. I added your commands above as an alternate, as retract-else-extend and extend-else-retract, since they don't return the switch to the off position.

correca commented 2 years ago

I think it is perfect to have both options. Many of the command pairs I propose are intended to be used in conjunction with the 3-position switches. I recently got a Warthog and I am trying to take advantage of the throttle control switches.