search

Munter / express-systemjs-translate

Express middleware to speed up systemjs development loads by running translations serverside
28 stars 4 forks source link

resolve symlinks before watching files #206

Closed gustavnikolaj closed 7 years ago

gustavnikolaj commented 7 years ago

We had a problem where files from an npm linked package wasn't triggering rebuilds properly. This fixes it so that the server will watch the real files and not the symlinks.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.3%) to 82.123% when pulling 402cf705981f0bf433819c18b0c8c58e9055c218 on feature/fixSymlinkWatching into 83cb39ccfbb27377dc371f23447c8811ac9ac6c4 on master.

Munter commented 7 years ago

Looks good to me. maybeRealPath should probably be made external and be tested separately

papandreou commented 7 years ago

Even though the implementation is Obviously Correct[TM] I agree with @Munter that it'd be nice to have a test.

gustavnikolaj commented 7 years ago

I don't test the use of maybeRealPath inside the middleware itself, but I do test it in isolation. Do you think that is enough? :-)

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.7%) to 85.083% when pulling 3aabcf15419a1df9dad864b45daa4c87525698da on feature/fixSymlinkWatching into 83cb39ccfbb27377dc371f23447c8811ac9ac6c4 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.7%) to 85.083% when pulling b4857eff726e5ff99125280d1a66701074156beb on feature/fixSymlinkWatching into 83cb39ccfbb27377dc371f23447c8811ac9ac6c4 on master.