Munter / grunt-reduce

A grunt kitchen that reduces your web ingredients down to their essence for optimal serving. Bon appétit!
MIT License
184 stars 13 forks source link

grunt-reduce doesn't work despite buildProduction works #4

Closed japboy closed 11 years ago

japboy commented 11 years ago

grunt-reduce doesn't work for me:

$ grunt reduce
Running "reduce" task
0.001 secs: registerRequireJsConfig
file:///Users/User/Documents/proj/index.html: Html: Conditional comment end marker seen without a start marker:  <![endif]
0.122 secs: loadAssets
0.434 secs: populate
0.000 secs: removeRelations
0.000 secs: removeRelations
0.001 secs: convertCssImportsToHtmlStyles
0.000 secs: removeAssets
0.002 secs: externalizeRelations
0.005 secs: mergeIdenticalAssets
0.016 secs: processImages
Fatal error: padding is not defined

In spite of buildProduction works for the same project:

$ buildProduction --outroot ./reduced --root ./proj
No input files specified, defaulting to file:///Users/User/Documents/proj/**/*.html
0.000 secs: registerRequireJsConfig
0.001 secs: registerLabelsAsCustomProtocols
file:///Users/User/Documents/proj/index.html: Html: Conditional comment end marker seen without a start marker:  <![endif]
0.166 secs: loadAssets
0.433 secs: populate
0.001 secs: fixBaseAssetsOfUnresolvedOutgoingRelationsFromHtmlFragments
0.000 secs: populate
0.000 secs: removeRelations
0.000 secs: removeRelations
0.002 secs: externalizeRelations
0.005 secs: mergeIdenticalAssets
0.013 secs: processImages
0.634 secs: spriteBackgroundImages
0.019 secs: processImages
0.008 secs: inlineKnockoutJsTemplates
0.022 secs: bundleRequireJs
0.000 secs: convertHtmlRequireJsMainToHtmlScript
0.001 secs: convertCssImportsToHtmlStyles
0.000 secs: removeDuplicateHtmlStyles
0.003 secs: bundleRelations
0.005 secs: bundleRelations
0.001 secs: removeNobundleAttribute
0.057 secs: inlineCssImagesWithLegacyFallback
0.024 secs: minifyAssets
0.000 secs: removeAssets
0.000 secs: removeAssets
2.211 secs: compressJavaScript
0.010 secs: inlineRelations
0.002 secs: inlineAngularJsTemplates
0.000 secs: setAsyncOrDeferOnHtmlScripts
0.000 secs: omitGetStaticUrlFunctionCall
0.001 secs: inlineRelations
0.054 secs: moveAssetsInOrder
3.660 secs: buildProduction
0.040 secs: writeAssetsToDisc
      Html  1   4.8 KB
       Css  2  62.1 KB
       Gif  4   7.1 KB
       Png  4   1.7 MB
JavaScript  2 149.0 KB
    Total: 13   1.9 MB
0.001 secs: writeStatsToStderr

assetgraph-builder is newer than the old one that grunt-reduce includes though.

any idea?

Munter commented 11 years ago

I should probably just update the assetgraph-builder version. Hang on...

Munter commented 11 years ago

I've just released grunt-reduce 0.1.6 with the lastest assetgraph-builder. Does this solve your problem?

japboy commented 11 years ago

Thanks @Munter It works!

Munter commented 11 years ago

Perfect. Thanks for reporting this.