Munter / hyperlink

A node library and command line tool to test the integrity of your internal an external hyperlinks
231 stars 24 forks source link

BUG: Checks pages outside its boundaries #154

Closed Munter closed 5 years ago

Munter commented 5 years ago

If any Html-asset that wasn't supposed to be a part of the graph expansion query somehow gets into the graph, hyperlink will treat it as a valid page that needs all its non-page dependencies checked.

Case in point:

<meta property="og:video" content="https://vimeo.com/49026951">

The open graph link responds with an Html asset, which then becomes a first-level citizen in the graph.

When hyperlink is running with the --internal switch, https://vimeo.com/49026951 get checked as part of the run as if you had called hyperlink directly on that URL.

If hyperlink is running with the --recursive switch activated, having https://vimeo.com/49026951 in the graph will result in a complete traversal of the entirety of https://vimeo.com

This case is equally relevant where no cross-domain jump is happening. Running hyperlink non-recursive should fo course also never result in another page being expanded upon, even if it was local