Closed papandreou closed 5 years ago
Awesome!
I think I need to have a look at changing the error messages for that case. The expected
property isn't really helping to surface the problem. And I should probably also add an expected
and actual
so reports become more explicit
Yeah, I am not super familiar with how those error reports are supposed to look. Feel free to change them :hugs:
LGTM, although I'm a little bit on the fence about assetgraph/lib/util/getHrefType
being part of the public api.
I think gethreftype should be pulled out into its own module. I can do that
https://www.npmjs.com/package/hreftypes now exists, and this PR is using it. I'll make a PR for switching assetgraph over soon
... except through a FileRedirect (implicit += index.html) with a trailing slash on the href.
https://github.com/webpack/webpack.js.org/pull/3332#issue-332087335