search

Munter / netlify-plugin-checklinks

Netlify build plugin check your links and asset references
BSD 3-Clause "New" or "Revised" License
89 stars 9 forks source link

dns-prefetch-check failing www.google-analytics.com #133

Open flvyu opened 4 years ago

flvyu commented 4 years ago

I did not make any changes to the links in the site, but started seeing this error.

✖ FAIL dns-prefetch-check www.google-analytics.com

expected: DNS exists www.google-analytics.com
actual: self signed certificate
at: public/404.html:1:6092 <link rel="preconnect dns-prefetch" href="https://www.google-analytics.com">
AnnieTaylorCHEN commented 4 years ago

I have exactly the same errors:

✖ FAIL dns-prefetch-check www.google-analytics.com
5:00:53 PM:   | operator: dns-prefetch-check
5:00:53 PM:   | expected: DNS exists www.google-analytics.com
5:00:53 PM:   |   actual: self signed certificate
5:00:53 PM:   |       at: public/404.html:1:22575 <link rel="preconnect dns-prefetch" href="https://www.google-analytics.com">

Anyone knows how to fix this? Installed the plugin from netlify UI, so I didn't do any manual configuration.

sachinsancheti1 commented 4 years ago

me too

sykaeh commented 3 years ago

I get a similar error for Google Fonts:

11:39:36 PM:   ✖ FAIL preconnect-check https://fonts.gstatic.com
11:39:36 PM:   | operator: preconnect-check
11:39:36 PM:   | expected: connection accepted https://fonts.gstatic.com
11:39:36 PM:   |   actual: self signed certificate
11:39:36 PM:   |       at: build/index.html:1:589 <link rel="preconnect" href="https://fonts.gstatic.com">
BenColwell131 commented 3 years ago

Did you find a solution for this?

sykaeh commented 3 years ago

I haven't looked into a fix for this, but I used this workaround for the moment (in the netlify.toml File):

[[plugins]]
  package = "netlify-plugin-checklinks"

  [plugins.inputs]
    skipPatterns = ['https://fonts.gstatic.com']

You can probably use the same workaround for www.google-analytics.com

BenColwell131 commented 3 years ago

Oh this worked for now, thank you!

Ben Colwell Creative Director Rubberduck

0867377087 www.rubberduck.ie

From: Sybil Ehrensberger notifications@github.com Sent: Thursday, January 14, 2021 12:07:12 PM To: Munter/netlify-plugin-checklinks netlify-plugin-checklinks@noreply.github.com Cc: bcolwell bencolwell131@gmail.com; Comment comment@noreply.github.com Subject: Re: [Munter/netlify-plugin-checklinks] dns-prefetch-check failing www.google-analytics.com (#133)

I haven't looked into a fix for this, but I used this workaround for the moment (in the netlify.toml File):

[[plugins]] package = "netlify-plugin-checklinks"

[plugins.inputs] skipPatterns = ['https://fonts.gstatic.com']

You can probably use the same workaround for www.google-analytics.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Munter/netlify-plugin-checklinks/issues/133#issuecomment-760155734, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGICD47YNQZBLLIG4NB63PLSZ3M7BANCNFSM4N364X4Q.

AnnieTaylorCHEN commented 3 years ago

I haven't looked into a fix for this, but I used this workaround for the moment (in the netlify.toml File):

[[plugins]]
  package = "netlify-plugin-checklinks"

  [plugins.inputs]
    skipPatterns = ['https://fonts.gstatic.com']

You can probably use the same workaround for www.google-analytics.com

I just tried this fix, replacing it with google analytics and it worked like a charm! Thanks!

mfanuzzi commented 2 years ago

I've had this issue as well when adding google fonts to preconnect:

  ✖ FAIL preconnect-check https://fonts.googleapis.com
  | operator: preconnect-check
  | expected: connection accepted https://fonts.googleapis.com
  |   actual: self signed certificate
  |       at: public/404.html:1:5071 <link rel="preconnect" href="https://fonts.googleapis.com" crossorigin="true">

  ✖ FAIL preconnect-check https://fonts.gstatic.com
  | operator: preconnect-check
  | expected: connection accepted https://fonts.gstatic.com
  |   actual: self signed certificate
  |       at: public/404.html:1:5150 <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin="true">

Initially I thought this had something to do with them not being in our default content security policy (Gatsby) but I've added them and no change. No console errors on the actual site in use so just limited to the plugin.

Adding "https://fonts.gstatic.com", "https://fonts.googleapis.com" to skipPatterns works but I wonder if this is the recommended approach @Munter? Is google really using a self-signed cert here?

Munter commented 2 years ago

@mfanuzzi I doubt that Google is using a self-signed certificate. I would say it's more likely that some random network error or intercept is occurring, or that the netlify runner is a container with outdated root-level certificates. None of those are issues I can really do anything about.