Munter / subfont

Command line tool to optimize your webfont loading. Aggressive subsetting based on your font use, self-hosting of Google fonts and preloading
MIT License
1.56k stars 29 forks source link

Logging that pyftsubset is missing despite not needing it #88

Closed Munter closed 4 years ago

Munter commented 4 years ago

When the fonttools package is not installed I get this log:


Running subfont version 4.2.2
 ✔ 0.000 secs: logEvents
 ✔ 0.054 secs: loadAssets
 ✔ 0.341 secs: populate
 ✔ 0.000 secs: checkIncompatibleTypes
 ✔ 0.001 secs: populate
/bin/sh: pyftsubset: command not found
 ✔ 0.020 secs: compressJavaScript
 ✔ 0.004 secs: writeAssetsToDisc
dist/index.html: 1 font (1 variant) in use, 59.2 kB total. Created subsets: 0 B total
  Tangerine:
    700 : 9/212 codepoints used, no subset font created
HTML/JS/CSS size increase: 888 B
Total savings: -888 B
Output written to file:///Users/pbm/git/plugin-subfont-demo/dist/ 

Content of index.html

<!DOCTYPE html>
<html lang="en">

<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Netlify-plugin-subfont Demo</title>

  <link href="https://fonts.googleapis.com/css?family=Tangerine:700" rel="stylesheet">
  <link rel="stylesheet" href="style.css">
</head>

<body>

  <div>
    <h1>Hello World!</h1>
  </div>

</body>

</html>

There are no references to local font files

Expected: No log message about pyftsubset when it is not needed