search

Munter / tolk

A file reader that promises to translate non-web assets to web assets given the available transpilers. Autoprefixing, sourcemaps and all!
27 stars 0 forks source link

add babel 6 support #128

Closed gustavnikolaj closed 8 years ago

gustavnikolaj commented 8 years ago

Accord landed babel 6 support in a newer version.

Babel 6 is split up into modules, and doesn't bundle any transforms any more, so I had to add a .babelrc file in the fixtures folder and add the es2015 preset, as well as replacing the babel dep with a dependency on babel-core.

Fixes the failing test which was mentioned in #46

Munter commented 8 years ago

You now have collaborator status on github and owner status on npm

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 93.103% when pulling ecc0adcc9cac20eb9863b2fa9130ad212d9a0711 on gustavnikolaj:feature/babel6 into 7af33f45fb55fb1f7e09c5f708f6dd60afdbef40 on Munter:master.

gustavnikolaj commented 8 years ago

Had to land a rather unpleasant workaround for a timeout caused by run-time requiring babel in accord. Version 6 of babel has notoriously bad performance on npm 2 because it relies on deduplication of modules that would happen with npm3.

This could be fixed by only using a single babel plugin, instead of the entire es2015 preset. I may change that later, but for now this is a one-to-one replacement of babel 5 to version 6.