Extrapolation to calo surface

MuonColliderSoft / ACTSTracking

GNU General Public License v3.0

0 stars 5 forks source link

Extrapolation to calo surface #20

Closed madbaron closed 2 months ago

madbaron commented 2 months ago

This PR adds the extrapolation of the tracks to the calorimeter surface.

This is still work in progress:

the code compiles
the addition of the track state at the calorimeter surface to the track is still missing
crashes at run time on the call to the propagator with a "TUnixSystem::Di... FATAL segmentation violation"

I am creating this ahead of time since I'll have now a couple of busy days, in case superexperts like @kkrizka @spagangriso or @pandreetto get a chance to take a look.

madbaron commented 2 months ago

Note to self: I think once the propagator crash is solved, the extrapolation should probably be moved to ACTS2Marlin_track inside Helpers.cxx

madbaron commented 2 months ago

Moved to Helpers.cxx. This also fixed the crash at runtime. Still missing the saving of the TrackState - coming soon.

madbaron commented 2 months ago

Ok great success so far. The extrapolation works and the states at the calorimeter face are compatible with those from the Refit processor.

One last thing missing: the cylindrical volume has no caps, so the forward tracks are still missing the extrapolation

madbaron commented 2 months ago

All good, ready to merge.

In the future / next release we'll want to:

start the extrapolation from the last spacepoint instead of the perigee
add extrapolation to muon system

Both these are not urgent for this release