search

MuonColliderSoft / ACTSTracking

GNU General Public License v3.0
0 stars 5 forks source link

expose max d0 setting #8

Closed madbaron closed 2 years ago

madbaron commented 2 years ago

Hi all,

This PR exposes the parameter regulating the maximum track d0 to allow dedicated long lived particle studies. (And a bunch of whitespace changes made by VS code...)

Cheers, Federico

kkrizka commented 2 years ago

Hi @madbaron ,

Thanks for the PR! I put a comment on the setting naming in the review.

Also could you please undo the vscode whitespace changes?

-- Karol Krizka

madbaron commented 2 years ago

Hi @kkrizka,

I've implemented your suggestions (and now grouped the d0 cut together with the other seeding parameters). In the original PR I didn't undo the white space changes, because I checked them and they all look for the better, but please insist if you disagree and I'll get rid of them!

kkrizka commented 2 years ago

Hi @madbaron ,

Code formatting is very subjective. Unless there is an official style being enforced by a CI, I would prefer that formatting changes are kept out of unrelated (to formatting) PR's.

Removing extra space at the end of a line and consistency changes are welcome though.

-- Karol Krizka

madbaron commented 2 years ago

Finally coming back to this :D I have capitalised the "I" as requested, as well as added an additional handle to steer the extrapolation direction. @kkrizka, please have a look and let me know if you'd like me to make some other style change.

The only thing I didn't undo is the formatting cleanup, because I don't know how to do it :D

Cheers, Federico