search

Muqsit / PlayerVaults

Per-player GUI-based vaults plugin for PocketMine-MP
https://poggit.pmmp.io/p/PlayerVaults
GNU Lesser General Public License v2.1
41 stars 33 forks source link

Issue with vaults #40

Closed BajanVlogs closed 6 years ago

BajanVlogs commented 6 years ago

Asynchronous Worker #1 thread/CRITICAL TypeError: "Argument 1 passed to pocketmine\nbt\NBTStream::readCompressed() must be of the type string, array given, called in /plugins/PlayerVaults-master/src/PlayerVaults/Task/FetchInventoryTask.php on line 104" (EXCEPTION) in "vendor/pocketmine/pocketmine-nbt/src/NBTStream" at line 88

TheNewHEROBRINEX commented 6 years ago

Change NetworkLittleEndianNBTStream to BigEndianNBTStream everywhere

Muqsit commented 6 years ago

@TheNewHEROBRINEX That may cause even more problems. Pocketmine uses NetworkLittleEndian for Tiles as it's supposed to be. https://github.com/pmmp/PocketMine-MP/blob/266a253c0395898fac53b07a184b60877f64f657/src/pocketmine/tile/Spawnable.php#L95

Muqsit commented 6 years ago

This bug happens because of https://github.com/Muqsit/PlayerVaults/blob/master/src/PlayerVaults/Task/FetchInventoryTask.php#L67 and https://github.com/Muqsit/PlayerVaults/blob/master/src/PlayerVaults/Task/FetchInventoryTask.php#L77 which are supposed to be null and not an empty array.