Muqsit / PlayerVaults

Per-player GUI-based vaults plugin for PocketMine-MP
https://poggit.pmmp.io/p/PlayerVaults
GNU Lesser General Public License v2.1
41 stars 33 forks source link

Drop support for JSON and YAML providers #51

Closed Muqsit closed 5 years ago

Muqsit commented 6 years ago

JSON and YAML aren't binary-safe providers and take in a lot more space than what MySQL takes. Let me quote this from the README.md:

Less harddrive space: The inventories are compressed using zlib and take very less hard drive space. To attain maximum compression, use MySQL. JSON and YAML require the data to be base64-encoded so MySQL takes nearly 66% lesser space than JSON and YAML. base64-encoding is required for JSON and YAML because they aren't binary safe.

PocketMine stores compressed NBT data in a plain file with a .dat extension and I think PlayerVaults should do the same. That way, there won't be any need to base64_encode the compressed NBT data.

Muqsit commented 5 years ago

Done in https://github.com/Muqsit/PlayerVaults/commit/842ff5c68db0da3711146b5359c2111597da4683