search

Muqsit / PlayerVaults

Per-player GUI-based vaults plugin for PocketMine-MP
https://poggit.pmmp.io/p/PlayerVaults
GNU Lesser General Public License v2.1
41 stars 33 forks source link

Shift Item deserialization to the main thread #61

Closed Muqsit closed 5 years ago

Muqsit commented 6 years ago

Item deserialization is currently done on a separate thread without copying the ItemFactory properties on the separate thread or initialization in any manner. This may lead to absurd behaviour with items because of the wrong item instance being fetched. Other problems arising from this issue include fetching the wrong item class when other plugins register custom items.

Muqsit commented 5 years ago

Done in https://github.com/Muqsit/PlayerVaults/commit/842ff5c68db0da3711146b5359c2111597da4683

isoz commented 5 years ago

Is this fully compatible with the old version?

Hmm, you removed old database so I guess not.

Muqsit commented 5 years ago

@isoz this isn't compatible with the old version but I'm currently working on a converter