Muqsit / Tebex

Tebex plugin for PocketMine-MP servers
https://poggit.pmmp.io/ci/Muqsit/Tebex
32 stars 6 forks source link

Remove pocketmine dependencies from tebex/api #6

Closed Muqsit closed 3 years ago

Muqsit commented 3 years ago

tebex/api must contain only the raw Tebex API requests and responses and code must only read the responses (and not manipulate it in any way). Any code which wishes to do so must come under tebex/handler, and methods such as TebexCommand::asOnlineFormattedString should be removed as they aren't really a part of the API that Tebex offers, but rather a result of manipulation of API responses. This will also make the task of extracting tebex/api into a separate library/virion easier.

Muqsit commented 3 years ago

https://github.com/Muqsit/Tebex/commit/233339fce38ce2856f4eab188e4e1a86381b7396