search

Muqsit / WorldStyler

Yet another World Editor plugin for PocketMine... except it's actually fast!
GNU Lesser General Public License v3.0
30 stars 6 forks source link

PMMP 4.0 Changes #27

Closed Ifera closed 4 years ago

Ifera commented 4 years ago

Implementing and adding on to the changes from #23, kudos to @xXNiceYT for making the initial PR.

Muqsit commented 4 years ago

Looks good. There's also a recent PM4 change where World::getChunk() returns either loaded chunk or an empty chunk. That will end up overriding an unloaded chunk with an empty chunk. World::getChunk() should be replaced with World::getOrLoadChunk().

Ifera commented 4 years ago

Looks good. There's also a recent PM4 change where World::getChunk() returns either loaded chunk or an empty chunk. That will end up overriding an unloaded chunk with an empty chunk. World::getChunk() should be replaced with World::getOrLoadChunk().

Other than this: https://github.com/Muqsit/WorldStyler/blob/03d032b1e6a08a37ace769382df2d87c49a96561/src/muqsit/worldstyler/shapes/async/tasks/AsyncChunksChangeTask.php#L109 All other instances were changed.