Murali-group / CyGraphSpace

A GraphSpace app for Cytoscape
GNU General Public License v3.0
1 stars 2 forks source link

Refs #20: Display URL of uploaded graph #22

Closed LHuang2019 closed 6 years ago

LHuang2019 commented 6 years ago

Overview: Creates a simple result panel that shows the status of the CyGraphSpace tasks.

CyGraphSpace version: 1.0.0 beta -> 1.0.1 beta

Result panel:

Other:

image

jlaw9 commented 6 years ago

Thank Li looks great!

The only thing I would change is the "link" button. I think it would look better to have the hyperlink laid out on its own line after the status like this: link: www.graphspace.org/graphs/XXXX

LHuang2019 commented 6 years ago

@jlaw9 Adding line after status could expand the task bar too much horizontally. Instead I moved the link to a new row. now it looks like this. Let me know what you think! image

tmmurali commented 6 years ago

This format looks good. Some suggestions:

(i) Is it possible to make the URL clickable?

(ii) Change the name of the tab from "CyGraphSpace Task" to "CyGraphSpace Status".

(iii) Should "Graph" be changed to "Graph name" or "Graph id"?

(iv) Most importantly, what is the definition of a "task" in this context? Murali

On Mon, Jul 23, 2018 at 8:50 PM Li Jun Huang notifications@github.com wrote:

@jlaw9 https://github.com/jlaw9 Adding line after status could expand the task bar too much horizontally. Instead I moved the link to a new row. now it looks like this. Let me know what you think! [image: image] https://user-images.githubusercontent.com/14338820/43110439-f347c86a-8eb9-11e8-9049-5947d7efee51.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Murali-group/CyGraphSpace/pull/22#issuecomment-407244477, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkWUC1fuKXbSBL36tsMu9EfpfwGtCuYks5uJm84gaJpZM4VZwzp .

LHuang2019 commented 6 years ago

The updated status bar: image

@tmmurali To answer your questions: (i) and (ii) Changes are made accordingly.

(iii) I use "Graph" to make all the text aligns in the same column. Otherwise I think "Graph name" is more appropriate, as the text on left of Graph is what shown in the "Graph Name" column of GraphSpace.

(iv). "Task" represents an instance of a graph upload/update action by the user.